Use runspace to acquire version to avoid CLM issues - #1869
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested review from
Sydney Smith (SydneyhSmith),
alerickson and
Anam Navied (anamnavi)
as code owners
September 5, 2025 17:53
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
September 5, 2025 19:08
| _psVersion = ps.AddScript("$PSVersionTable").Invoke<Hashtable>()[0]["PSVersion"].ToString(); | ||
| } | ||
|
|
||
| _psVersion = System.Management.Automation.Runspaces.Runspace.DefaultRunspace.Version.ToString(); |
There was a problem hiding this comment.
do we potentially need the null coalescing operator for any of these properties?
Anam Navied (anamnavi)
approved these changes
Sep 5, 2025
Anam Navied (anamnavi)
left a comment
Anam Navied (anamnavi)
left a comment
Member
There was a problem hiding this comment.
LGTM, left a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a new helper method to retrieve the user agent string and simplifies how the PowerShell version is determined for user agent construction. The changes improve maintainability and reliability by reducing the use of PowerShell scripts and exposing a direct way to access the user agent string.
User agent string handling:
GetUserStringtoInternalHooksthat returns the user agent string viaUserAgentInfo.UserAgentString().PowerShell version detection:
UserAgentInfoto retrieve the PowerShell version usingRunspace.DefaultRunspace.Versioninstead of executing a PowerShell script, simplifying and making the version detection more robust.PR Context
Fixes #1676
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.